tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rémy Maucherat <r...@apache.org>
Subject Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java
Date Thu, 23 Jan 2014 15:01:37 GMT
2014/1/23 Mark Thomas <markt@apache.org>

> > - Call onClose before actually closing anything (sending a close message
> closes the endpoint).
>
> -1 (veto) for a specification violation
>
> Section 2.1.5 requires that:
> "the implementation must attempt to send the websocket close frame prior
> to calling the onClose() method of the websocket endpoint."
>

Ok, but then onClose has the endpoint already closed, and it cannot do
anything (like send messages).

> - After using a blocking send, clear the client buffer in case it gets
> reused (I have no idea why this is needed ...).
>
> This seems wrong (although I don't see the harm). I'd really expect the
> client to take care of that.
>

Well, yes, I agree !

Rémy

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message