tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1561023 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Fri, 24 Jan 2014 14:50:29 GMT
2014/1/24  <rjung@apache.org>:
> Author: rjung
> Date: Fri Jan 24 14:31:02 2014
> New Revision: 1561023
>
> URL: http://svn.apache.org/r1561023
> Log:
> And then there were three (and a comment).
>
> Modified:
>     tomcat/tc6.0.x/trunk/STATUS.txt

>
>  * Update sample Eclipse IDE project to use JUnit 4 and
> @@ -40,15 +40,17 @@ PATCHES PROPOSED TO BACKPORT:
>    when several JDKs are configured.
>    Remove unused JUnit-related properties from Ant build files.
>    https://people.apache.org/~kkolinko/patches/2014-01-24_tc6_junit4_eclipse.patch
> -  +1: kkolinko, markt
> +  +1: kkolinko, markt, rjung
>    -1:
> +  rjung: there are some additional junit references in file test/build.xml.
> +         I wasn't able to make them work. Maybe more cleanup opportunity?


I've run the current tests directly in Eclipse IDE with
1. select "/test"
2. right-click
3. Run As > JUnit test

Regarding test/build.xml, I am leaving it as is at the moment and am
fixing only those build files that we actually use.

Technically in test/build.xml:
1. I suspect that <path id="tomcat.test.classpath">  may need additional
 jars beyond "tomcat-juli.jar" and "tomcat-coyote.jar"
2. Latest versions of JUnit 4 (4.9 and later?) have separate junit.jar
and hamcrest.jar. Technically
the build.xml does not specify, what version of JUnit it is using.

As the general roadmap I would like to include tests into main
build.xml, but as all current tests are standalone ones (they do not
run Tomcat), I feel no urge for that. They can be successfully run
from within IDE.

Technically, I started tomcat6-testing branch to widen testing in
Tomcat 6,  but it is not ready yet.
Though it have been useful during several backports.
https://svn.apache.org/repos/asf/tomcat/tc6.0.x/branches/tomcat6-testing/BRANCH-README.txt

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message