tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1560702 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsRemoteEndpointImplBase.java WsSession.java pojo/PojoEndpointBase.java
Date Thu, 23 Jan 2014 15:09:46 GMT
On 23/01/2014 15:01, Rémy Maucherat wrote:
> 2014/1/23 Mark Thomas <markt@apache.org>
> 
>>> - Call onClose before actually closing anything (sending a close message
>> closes the endpoint).
>>
>> -1 (veto) for a specification violation
>>
>> Section 2.1.5 requires that:
>> "the implementation must attempt to send the websocket close frame prior
>> to calling the onClose() method of the websocket endpoint."
>>
> 
> Ok, but then onClose has the endpoint already closed, and it cannot do
> anything (like send messages).

I'd need to go back and check the archives but the I think the
expectation from the EG was that onClose() would be used to clean up
resources rather than anything else.

It is always possible that I have misunderstood the intention of the
spec here but it looks to be pretty clear.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message