tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1559662 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java
Date Mon, 20 Jan 2014 10:00:31 GMT
Author: markt
Date: Mon Jan 20 10:00:31 2014
New Revision: 1559662

URL: http://svn.apache.org/r1559662
Log:
Remove unused code

Modified:
    tomcat/trunk/java/org/apache/catalina/connector/Request.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1559662&r1=1559661&r2=1559662&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Mon Jan 20 10:00:31 2014
@@ -202,11 +202,6 @@ public class Request
      */
     protected boolean sslAttributesParsed = false;
 
-    /**
-     * List of read only attributes for this Request.
-     */
-    private final HashMap<String,Object> readOnlyAttributes = new HashMap<>();
-
 
     /**
      * The preferred Locales associated with this Request.
@@ -1413,12 +1408,6 @@ public class Request
     @Override
     public void removeAttribute(String name) {
         // Remove the specified attribute
-        // Check for read only attribute
-        // requests are per thread so synchronization unnecessary
-        if (readOnlyAttributes.containsKey(name)) {
-            return;
-        }
-
         // Pass special attributes to the native layer
         if (name.startsWith("org.apache.tomcat.")) {
             coyoteRequest.getAttributes().remove(name);
@@ -1466,12 +1455,6 @@ public class Request
         }
 
         // Add or replace the specified attribute
-        // Check for read only attribute
-        // requests are per thread so synchronization unnecessary
-        if (readOnlyAttributes.containsKey(name)) {
-            return;
-        }
-
         // Do the security check before any updates are made
         if (Globals.IS_SECURITY_ENABLED &&
                 name.equals(Globals.SENDFILE_FILENAME_ATTR)) {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message