Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 888D210C91 for ; Fri, 1 Nov 2013 05:37:06 +0000 (UTC) Received: (qmail 45035 invoked by uid 500); 1 Nov 2013 05:37:03 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 44998 invoked by uid 500); 1 Nov 2013 05:37:00 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 44989 invoked by uid 99); 1 Nov 2013 05:36:59 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Nov 2013 05:36:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Nov 2013 05:36:58 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 012512388831 for ; Fri, 1 Nov 2013 05:36:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1537827 - in /tomcat/maven-plugin/trunk: tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/ tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/ Date: Fri, 01 Nov 2013 05:36:37 -0000 To: dev@tomcat.apache.org From: olamy@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20131101053638.012512388831@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: olamy Date: Fri Nov 1 05:36:37 2013 New Revision: 1537827 URL: http://svn.apache.org/r1537827 Log: [MTOMCAT-217] configure a pre define http port for standalone jar Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java?rev=1537827&r1=1537826&r2=1537827&view=diff ============================================================================== --- tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java (original) +++ tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java Fri Nov 1 05:36:37 2013 @@ -103,11 +103,12 @@ public abstract class AbstractExecWarMoj defaultValue = "${project.artifactId}-${project.version}-war-exec.jar", required = true) protected String finalName; - /** + /** * Skip the execution + * * @since 2.2 */ - @Parameter( property = "maven.tomcat.skip", defaultValue = "false" ) + @Parameter(property = "maven.tomcat.skip", defaultValue = "false") private boolean skip; /** @@ -204,6 +205,14 @@ public abstract class AbstractExecWarMoj @Parameter(property = "maven.tomcat.exec.war.connectorHttpProtocol", defaultValue = "HTTP/1.1", required = true) protected String connectorHttpProtocol; + /** + * configure a default http port for the standalone jar + * + * @since 2.2 + */ + @Parameter( property = "maven.tomcat.exec.war.httpPort" ) + protected String httpPort; + public void execute() throws MojoExecutionException, MojoFailureException { @@ -270,6 +279,11 @@ public abstract class AbstractExecWarMoj properties.put( Tomcat7Runner.ACCESS_LOG_VALVE_FORMAT_KEY, accessLogValveFormat ); properties.put( Tomcat7Runner.HTTP_PROTOCOL_KEY, connectorHttpProtocol ); + if ( httpPort != null ) + { + properties.put( Tomcat7Runner.HTTP_PORT_KEY, httpPort ); + } + os = new ArchiveStreamFactory().createArchiveOutputStream( ArchiveStreamFactory.JAR, execWarJarOutputStream ); Modified: tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java?rev=1537827&r1=1537826&r2=1537827&view=diff ============================================================================== --- tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java (original) +++ tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java Fri Nov 1 05:36:37 2013 @@ -78,6 +78,11 @@ public class Tomcat7Runner */ public static final String HTTP_PROTOCOL_KEY = "connectorhttpProtocol"; + /** + * key for default http port defined in the plugin + */ + public static final String HTTP_PORT_KEY = "httpPort"; + public int httpPort; Modified: tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java?rev=1537827&r1=1537826&r2=1537827&view=diff ============================================================================== --- tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java (original) +++ tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java Fri Nov 1 05:36:37 2013 @@ -138,6 +138,14 @@ public class Tomcat7RunnerCli { tomcat7Runner.serverXmlPath = line.getOptionValue( serverXmlPath.getOpt() ); } + + String port = tomcat7Runner.runtimeProperties.getProperty( Tomcat7Runner.HTTP_PORT_KEY ); + if ( port != null) + { + tomcat7Runner.httpPort = Integer.parseInt( port ); + } + + // cli win for the port if ( line.hasOption( httpPort.getOpt() ) ) { tomcat7Runner.httpPort = Integer.parseInt( line.getOptionValue( httpPort.getOpt() ) ); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org