tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremy Boynes <jboy...@apache.org>
Subject Re: XML parsing config clean-up
Date Sat, 23 Nov 2013 04:14:08 GMT
On Nov 22, 2013, at 8:24 AM, Mark Thomas <markt@apache.org> wrote:

> Signed PGP part
> On 22/11/2013 16:18, Jeremy Boynes wrote:
> > On Nov 22, 2013, at 5:40 AM, Mark Thomas <markt@apache.org> wrote:
> >
> >> On 22/11/2013 13:04, Konstantin Kolinko wrote:
> >>> 2013/11/22 Mark Thomas <markt@apache.org>:
> > ...
> >>
> >>> It does not mention anything else.
> >>>
> >>> There might be 3rd-party tag libraries that do not validate. I
> >>> think it is good to have a separate option.
> >>
> >> OK. That is enough to nudge me off the fence. I'll get that code
> >> re-instated. Another advantage is that 7.0.x and 8.0.x will the
> >> same code.
> >
> > Is the change backward compatible in 7.0.x? E.g. does "validating"
> > init-param for JspServlet still work?
> 
> Where is (was?) that in the 7.0.x code base? I can;t see it now and I
> don't recall removing it from 7.0.x.

This was the change:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/EmbeddedServletOptions.java?r1=1155369&r2=1544198&diff_format=h

Looking at the code, it looks the option wouldn't work in the first place as the default value
in ParserUtils is false and ESO never sets the value true.

Cheers
Jeremy



Mime
View raw message