tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kpreis...@apache.org
Subject svn commit: r1531600 - in /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard: DrawboardEndpoint.java Room.java
Date Sat, 12 Oct 2013 22:03:10 GMT
Author: kpreisser
Date: Sat Oct 12 22:03:10 2013
New Revision: 1531600

URL: http://svn.apache.org/r1531600
Log:
Update some comments.

Modified:
    tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java
    tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java

Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java?rev=1531600&r1=1531599&r2=1531600&view=diff
==============================================================================
--- tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java
(original)
+++ tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/DrawboardEndpoint.java
Sat Oct 12 22:03:10 2013
@@ -158,7 +158,7 @@ public final class DrawboardEndpoint ext
                         // (starting with char '1'), and pong messages (starting
                         // with char '0').
                         // Draw messages should look like this:
-                        // ID|type,colR,colB,colG,colA,thickness,x1,y1,x2,y2
+                        // ID|type,colR,colB,colG,colA,thickness,x1,y1,x2,y2,lastInChain
 
                         boolean dontSwallowException = false;
                         try {

Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java?rev=1531600&r1=1531599&r2=1531600&view=diff
==============================================================================
--- tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java (original)
+++ tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard/Room.java Sat Oct 12
22:03:10 2013
@@ -229,7 +229,7 @@ public final class Room {
 
 
     /**
-     * Broadcasts the given drawboard message to all connected players.
+     * Broadcasts the given drawboard message to all connected players.<br>
      * Note: For DrawMessages, please use
      * {@link #broadcastDrawMessage(DrawMessage)}
      * as this method will buffer them and prefix them with the correct
@@ -274,7 +274,7 @@ public final class Room {
     private void broadcastTimerTick() {
         // For each Player, send all per Player buffered
         // DrawMessages, prefixing each DrawMessage with the player's
-        // lastReceuvedMessageId.
+        // lastReceivedMessageId.
         // Multiple messages are concatenated with "|".
 
         for (Player p : players) {
@@ -329,6 +329,7 @@ public final class Room {
     public void shutdown() {
         roomExecutor.shutdown();
         drawmessageBroadcastTimer.cancel();
+        // TODO: Dispose of BufferedImage and Graphics2D
     }
 
 
@@ -337,7 +338,7 @@ public final class Room {
      * {@link Room} and the {@link Client}.<br><br>
      *
      * Note: This means a player object is actually a join between Room and
-     * Endpoint.
+     * Client.
      */
     public final class Player {
 
@@ -356,8 +357,6 @@ public final class Room {
 
         /**
          * Buffered DrawMessages that will be sent by a Timer.
-         * TODO: This should be refactored to be in a Room-Player join class
-         * as this is room-specific.
          */
         private final List<DrawMessage> bufferedDrawMessages =
                 new ArrayList<>();



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message