Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 74.125.82.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CABzHfV=NvVD0jTOX22LCxKcaP+Xpev5HcJBpF+sxZ=9B151U0Q@mail.gmail.com>
References: <000c01ceb9fe$cd29bf20$677d3d60$@apache.org>
	<5242FAC1.8010107@apache.org>
	<000d01ceba05$0c4786a0$24d693e0$@apache.org>
	<5243072A.80502@apache.org>
	<000f01ceba08$9b21c770$d1655650$@apache.org>
	<CAOGo0VZycY8LqOnhEH8poqAi7VoDbP6Q-cQTmL9QddsCw56XUg@mail.gmail.com>
	<CABzHfV=NvVD0jTOX22LCxKcaP+Xpev5HcJBpF+sxZ=9B151U0Q@mail.gmail.com>
Date: Fri, 27 Sep 2013 02:35:48 +0100
Message-ID: 
 <CAOGo0VbUK3APixjp0ypwx=PUC20jUOLyPhz8NXVrUm5Z=vbekg@mail.gmail.com>
Subject: Re: International characters in source files and SVN commit messages
 (was: RE:r1525975)
From: sebb <sebbaz@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 26 September 2013 23:29, Konstantin Kolinko <knst.kolinko@gmail.com> wro=
te:
> 2013/9/26 sebb <sebbaz@gmail.com>:
>> On 25 September 2013 17:02, Konstantin Prei=DFer <kpreisser@apache.org> =
wrote:
>>> Mark,
>>>
>>>> -----Original Message-----
>>>> From: Mark Thomas [mailto:markt@apache.org]
>>>> Sent: Wednesday, September 25, 2013 5:54 PM
>>>
>>>> I'd say yes. Property files are a 'special' case:
>>>> http://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-
>>>> resource-properties-with-resourcebundle
>>>
>>> OK, thank you for the clarification.
>>>
>>>> It doesn't bother me but I'm only one committer. I think this falls
>>>> under the category if someone cares enough about the commit e-mails
>>>> using UTF-8 then they need to work with infra to make that happen. I'm
>>>> happy with things as they are.
>>
>> There is a property that can be used to change the encoding used by
>> the SVN mailer, for example:
>>
>> svn:mime-type text/xml; charset=3Dutf-8
>>
>> Make sure this agrees with the contents and any xml encoding attribute.
>>
>
> -1 for changing svn:mime-type in such a way.
> Placing an encoding into svn:mime-type is wrong, as
> a) It is not portable. (Git does not have svn properties).

There are other svn properties that are required, so that does not make sen=
se.

> b) It is hard to keep in sync.  Beware that case may matter for some
> software (UTF-8 vs utf-8).

How often does the encoding change?

> ( c) You may be relying on an undocumented feature. I remember some
> long discussions several years ago on whether file encoding can be
> part of svn:mime-type, or it should be a separate property, with no
> clear outcome.

See http://opensource.perlig.de/svnmailer/doc-1.0/#groups-charset-property

> http://subversion.tigris.org/issues/show_bug.cgi?id=3D2329
> http://subversion.tigris.org/issues/show_bug.cgi?id=3D2194
> )
>
> Regarding whoweare.xml file,  you need to add explicit encoding to the
> top of the file (like it is done in
> tc7.0.x/trunk/webapps/docs/changelog.xml).  Without that I consider
> those files as ISO-8859-1, like the rest of our sources.

The default for XML is UTF-8.

>
> I think commit mailer should treat the files as ISO-8859-1, as such

XML is UTF-8 by default

> interpretation does not lose any data and as that is the format of
> unified diff.

Not sure about those last two assertions.

> In the past there were several cases when accented characters in
> Tomcat's changelog files were corrupted during editing (due to a
> conversion done in someone's editor). It was seen in commit message.
> Last time it happened two or three years ago.

That may be so, but I'm not sure what bearing that has on the svn
commit message encoding.

> http://svn.apache.org/r999983
> http://svn.apache.org/r1196769
>
> As of now, several xml files in Tomcat (those changelogs) are
> officially UTF-8, and I am OK with people using accented characters
> for new text there until something breaks.
> (Personally, I will probably still use numeric entities, as I do not
> have those characters on my keyboard.)
>
> AFAIK, TortoiseSVN diff viewer has some logic to autodetect the use of UT=
F-8.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org