Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.212.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20130815205138.D394C2388980@eris.apache.org>
References: <20130815205138.D394C2388980@eris.apache.org>
Date: Wed, 11 Sep 2013 04:24:55 +0400
Message-ID: 
 <CABzHfVk7bNVWqkQJaL2e-WMui9C-2YpA+E7xwEcy2PUqTj62dg@mail.gmail.com>
Subject: Re: svn commit: r1514485 - in /tomcat/trunk/java/org/apache:
 coyote/ajp/AbstractAjpProcessor.java coyote/http11/AbstractOutputBuffer.java
 coyote/spdy/SpdyProcessor.java tomcat/util/http/HttpMessages.java
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

2013/8/16  <markt@apache.org>:
> Author: markt
> Date: Thu Aug 15 20:51:38 2013
> New Revision: 1514485
>
> URL: http://svn.apache.org/r1514485
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55399
> Have the message in the response line use the locale set for the response.
>
> Modified:
>     tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
>     tomcat/trunk/java/org/apache/coyote/http11/AbstractOutputBuffer.java
>     tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java
>     tomcat/trunk/java/org/apache/tomcat/util/http/HttpMessages.java
>

>
> +
> +    public static HttpMessages getInstance(Locale locale) {
> +        HttpMessages result = instances.get(locale);
> +        if (result == null) {
> +            StringManager sm = StringManager.getManager(
> +                    "org.apache.tomcat.util.http.res", locale);
> +            if (Locale.getDefault().equals(sm.getLocale())) {
> +                result = DEFAULT;
> +            } else {
> +                result = new HttpMessages(sm);
> +            }
> +            instances.put(locale, result);
> +        }
> +        return result;
> +    }
> +

What a bit bothers me here (and in earlier changes to ErrorReportValve
etc. - r1514496) is that locale is provided by client and thus the
caches here and in StringManager can grow, instead of being limited to
the few locales that are actually bundled with Tomcat.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org