Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: error (nike.apache.org: local policy)
Sender: Jeremy Boynes <jeremy@boynes.com>
From: Jeremy Boynes <jboynes@apache.org>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_EA111A53-E096-4A8F-8C5B-7CCF2F49FEAE";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Message-Id: <90E3102C-4C6B-4D26-87D8-0F8D85D7DAC1@apache.org>
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
Subject: Issues in Apache Taglibs 1.2.0-RC1
Date: Sat, 14 Sep 2013 09:09:05 -0700
References: <9B99E67B-DEB7-4F8C-BFF5-E16064840982@apache.org>
 <CAOGo0VbyvBoATA54JUzfaXx7FMDqUyHky6ef_q_fWGOc2f_MYA@mail.gmail.com>
To: "Tomcat Developers List" <dev@tomcat.apache.org>
In-Reply-To: 
 <CAOGo0VbyvBoATA54JUzfaXx7FMDqUyHky6ef_q_fWGOc2f_MYA@mail.gmail.com>

--Apple-Mail=_EA111A53-E096-4A8F-8C5B-7CCF2F49FEAE
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=iso-8859-1

On Aug 7, 2013, at 4:41 AM, sebb <sebbaz@gmail.com> wrote:

> On 2 August 2013 20:32, Jeremy Boynes <jboynes@apache.org> wrote:
>> A proposed release candidate Apache Taglibs 1.2.0-RC1 is now =
available for voting.
>>=20
>> This is release candidate for an implementation of JSTL 1.2 and can =
be obtained from the staging repo at:
>>  =
https://repository.apache.org/content/repositories/orgapachetomcat-053/
>>=20
>> The source distribution can be obtained from:
>>  =
https://repository.apache.org/content/repositories/orgapachetomcat-053/org=
/apache/taglibs/taglibs-standard/1.2.0-RC1/
>>=20
>> The proposed 1.2.0-RC1 candidate is:
>> [X] Broken - do not release
>> [ ] Alpha - can be released as 1.2.0-RC1 alpha
>>=20
>> This is the first release in a long time, and the first since =
switching to Maven. If there are issues, please list all concerns so =
they can be addressed.
>=20
> Please include the SVN tag and revision number in all vote e-mails.
>=20
> Otherwise it's not possible to check provenance of the the source =
files.
> Nor can one check if there are files missing from the source archive
> (or accidentally added).
>=20
> A link to the KEYS file should also be included so the sigs can be =
checked.
>=20
> =3D=3D
>=20
> The NOTICE file says:
>>>>=20
> Apache Tomcat Standard Taglib
> Copyright 2001-2012 The Apache Software Foundation
>=20
> This product includes software developed by
> The Apache Software Foundation (http://www.apache.org/).
> <<<
>=20
> The year should possibly be updated to 2013.
>=20
> "developed by" MUST be changed to "developed at"
>=20
> The NOTICE files in the META-INF jar directories don't have the full
> name of the component. The name must include the "Apache Tomcat
> Standard Taglib" prefix. However, the NOTICE files do say "developed
> at".
>=20
> There are several files without AL headers.
>=20
> Several source files contain the SVN tag $Date$.
> This is generated using the local timezone, so the source archive will
> be different depending where it is generated. Best to avoid $Date$; if
> you want a date, use $Id$ instead, though $Revision$ should be
> sufficient.
>=20
> The source archive top-level directory includes the suffix RC1; that =
is unusual.
>=20
> The file JSTLVariableStackTest.java does not have svn:eolstyle native =
set.
> The file ParamSupport.java is marked as executable in SVN props.

I think addressed those issues in the following changes:
http://svn.apache.org/r1512150
http://svn.apache.org/r1512151
http://svn.apache.org/r1512153
http://svn.apache.org/r1512158
http://svn.apache.org/r1512166
http://svn.apache.org/r1512172

except for the "several files without AL headers." I'll look to see =
which those are but pointers would help.
After those changes do you see any additional problems?

Thanks
Jeremy

--Apple-Mail=_EA111A53-E096-4A8F-8C5B-7CCF2F49FEAE
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJSNIohAAoJEKVK0I6noCM8IbcIAIiirDv64UGPbcITpf36Ienb
fK79FsYyai9rEcH40yZTmOAUAeMHdQ9GGpKOyOWlEDeuehp8aaPpmIXWMGBE1VSW
4ySglnZQZ+eXoEjY5MjEYYU3h+kS9H1+Cp1Ojv7YOPquSj04c2GNkfdVtwn+0rjY
vetLOXjBgDOJ0OhmsNtMk/nB4L71AI6udkfu1QYNc1bcOW95IuLPe++S0DVYMSj6
sUCTjX0Pg8wFtzc6CAGb6VH7Q4iMN9QD0PFr8hkGZL5NR2avV2nBhazN8DrHvK/3
YQI1cbSsD04VPDxsSt49gW3M8JssLvd77HY7szw1XqpxaMwP6SJys9R48XIzFYQ=
=Oy5T
-----END PGP SIGNATURE-----

--Apple-Mail=_EA111A53-E096-4A8F-8C5B-7CCF2F49FEAE--