tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1519804 - /tomcat/trunk/build.xml
Date Wed, 04 Sep 2013 12:57:56 GMT
2013/9/4 Konstantin Kolinko <knst.kolinko@gmail.com>:
> 2013/9/3  <markt@apache.org>:
>> Author: markt
>> Date: Tue Sep  3 19:26:17 2013
>> New Revision: 1519804
>>
>> URL: http://svn.apache.org/r1519804
>> Log:
>> Tomcat only uses package-info.java files for Javadoc so don't bother creating empty
class files from them.
>>
>> Modified:
>>     tomcat/trunk/build.xml
>>
>
> 1. Docs [1] say that those files are created so that Ant will stop
> recompiling them.
>
> Beware that re-compilation time may increase.
>

Another solution could be to filter out those unwanted class files
when packing a jar.

> 2. The createMissingPackageInfoClass option is @since Ant 1.8.3.
>
> BUILDING.txt for trunk says that we require Ant 1.8.x.
> I think it is the time to update that.
> My opinion is that we may say that we require 1.9.2 (the current
> version of Ant).
>
> [1] http://ant.apache.org/manual/Tasks/javac.html

Best regards,
Konstantin Kolinko

>> Modified: tomcat/trunk/build.xml
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1519804&r1=1519803&r2=1519804&view=diff
>> ==============================================================================
>> --- tomcat/trunk/build.xml (original)
>> +++ tomcat/trunk/build.xml Tue Sep  3 19:26:17 2013
>> @@ -611,7 +611,8 @@
>>             optimize="${compile.optimize}"
>>             excludes="**/.svn/**"
>>             encoding="ISO-8859-1"
>> -           includeAntRuntime="true" >
>> +           includeAntRuntime="true"
>> +           createMissingPackageInfoClass="false" >
>>        <compilerarg value="-Xlint:unchecked"/>
>>        <classpath refid="compile.classpath" />
>>          <exclude name="org/apache/naming/factory/webservices/**" />
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message