tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1519456 - /tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
Date Mon, 02 Sep 2013 14:56:01 GMT
Author: markt
Date: Mon Sep  2 14:56:00 2013
New Revision: 1519456

URL: http://svn.apache.org/r1519456
Log:
Researched the TODOs from the review of the AJP code against the list of actions.

Modified:
    tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java

Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java?rev=1519456&r1=1519455&r2=1519456&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java Mon Sep  2 14:56:00
2013
@@ -380,8 +380,6 @@ public abstract class AbstractAjpProcess
 
         } else if (actionCode == ActionCode.RESET) {
             // NO-OP
-            // TODO Check if this is really a NO-OP for AJP or if something
-            // needs to be done here
 
         } else if (actionCode == ActionCode.REQ_SSL_ATTRIBUTE ) {
 
@@ -429,7 +427,6 @@ public abstract class AbstractAjpProcess
             // AJP as the reverse proxy controls that connection.
 
         } else if (actionCode == ActionCode.REQ_HOST_ATTRIBUTE) {
-
             // Get remote host name using a DNS resolution
             if (request.remoteHost().isNull()) {
                 try {
@@ -442,13 +439,11 @@ public abstract class AbstractAjpProcess
 
         } else if (actionCode == ActionCode.REQ_HOST_ADDR_ATTRIBUTE) {
             // NO-OP
-            // TODO Check if this is really a NO-OP for AJP or if something
-            // needs to be done here
+            // Automatically populated during prepareRequest()
 
         } else if (actionCode == ActionCode.REQ_LOCAL_NAME_ATTRIBUTE) {
             // NO-OP
-            // TODO Check if this is really a NO-OP for AJP or if something
-            // needs to be done here
+            // Automatically populated during prepareRequest()
 
         } else if (actionCode == ActionCode.REQ_LOCAL_ADDR_ATTRIBUTE) {
             // Copy from local name for now, which should simply be an address
@@ -456,13 +451,11 @@ public abstract class AbstractAjpProcess
 
         } else if (actionCode == ActionCode.REQ_REMOTEPORT_ATTRIBUTE) {
             // NO-OP
-            // TODO Check if this is really a NO-OP for AJP or if something
-            // needs to be done here
+            // This information is not available when using the AJP protocol
 
         } else if (actionCode == ActionCode.REQ_LOCALPORT_ATTRIBUTE) {
             // NO-OP
-            // TODO Check if this is really a NO-OP for AJP or if something
-            // needs to be done here
+            // Automatically populated during prepareRequest()
 
         } else if (actionCode == ActionCode.REQ_SET_BODY_REPLAY) {
             // Set the given bytes as the content



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message