tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Preißer <verlag.preis...@t-online.de>
Subject RE: Download links broken on main web site?
Date Wed, 11 Sep 2013 14:45:19 GMT
Hi,

> -----Original Message-----
> From: Mark Thomas [mailto:markt@apache.org]
> Sent: Wednesday, September 11, 2013 4:38 PM
> To: Tomcat Developers List
> Cc: Yoav Shapira
> Subject: Re: Download links broken on main web site?
> 
> On 11/09/2013 15:29, Yoav Shapira wrote:
> > Browsing http://tomcat.apache.org and clicking on the links in the
> > left-hand menu's Download section, e.g. this one for Tomcat 7.0, leads
> > to a broken page: http://tomcat.apache.org/download-70.cgi.
> 
> Dropping infra@ from the cc list. This looks like our problem at the moment.
> 
> I'm fairly sure the recent format updates have broken the download pages.
> Just trying to figure out how that happened.

My bad - it seems the IE conditional comments which I added to fix the layout in IE 8 now
break the CGI script - it seems to treat the conditional comments as CGI commands.

Sorry, I have no experience with the CGI scripts (and why they interpret HTML comments). To
restore the download pages, you can revert the IE8 fixes:


Index: xdocs/stylesheets/tomcat-site.xsl
===================================================================
--- xdocs/stylesheets/tomcat-site.xsl	(revision 1521880)
+++ xdocs/stylesheets/tomcat-site.xsl	(working copy)
@@ -58,8 +58,6 @@
        specified in the XML declaration.
   -->
   <link href="stylesheets/tomcat.css" rel="stylesheet" type="text/css"/>
-  <!-- CSS hack for IEs ? 9. -->
-  <xsl:comment><![CDATA[[if IE]><link href="stylesheets/tomcat-ie-fix.css"
rel="stylesheet" type="text/css"/><![endif]]]></xsl:comment>
   <link href="stylesheets/tomcat-printer.css" rel="stylesheet" type="text/css" media="print"/>
     <xsl:apply-templates select="meta"/>
     <title><xsl:value-of select="$project/title"/> - <xsl:value-of select="properties/title"/></title>
@@ -86,11 +84,7 @@
   <body>
   <div id="wrapper">
   <!-- Header -->
-  <!-- Workaround for old IEs: use <div id="..."> instead of <header id="...">,
otherwise the CSS will not apply.
-       IE ? 10 dropped support for conditional comments in Standards Mode, so there it will
use <header>. -->
-  <xsl:comment><![CDATA[[if IE]><div id="header"><![endif]]]></xsl:comment><xsl:comment><![CDATA[[if
!IE]>]]></xsl:comment>
   <header id="header">
-    <xsl:comment><![CDATA[<![endif]]]></xsl:comment>
     <div>
       <div>
           <xsl:variable name="src">
@@ -119,10 +113,7 @@
         <div style="clear: left;"/>
       </div>
     </div>
-	<!-- Workaround for old IEs, see above. -->
-    <xsl:comment><![CDATA[[if IE]></div><![endif]]]></xsl:comment><xsl:comment><![CDATA[[if
!IE]>]]></xsl:comment>
   </header>
-  <xsl:comment><![CDATA[<![endif]]]></xsl:comment>
   
   
   <div id="middle">
@@ -149,17 +140,12 @@
   </div>
 
   <!-- Footer -->
-  <!-- Workarounds for old IEs, see above. -->
-  <xsl:comment><![CDATA[[if IE]><div id="footer"><![endif]]]></xsl:comment><xsl:comment><![CDATA[[if
!IE]>]]></xsl:comment>
   <footer id="footer">
-    <xsl:comment><![CDATA[<![endif]]]></xsl:comment>
     Copyright © 1999-2013, The Apache Software Foundation
     <br/>
     Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat
     project logo are trademarks of the Apache Software Foundation.
-    <xsl:comment><![CDATA[[if IE]></div><![endif]]]></xsl:comment><xsl:comment><![CDATA[[if
!IE]>]]></xsl:comment>
   </footer>
-  <xsl:comment><![CDATA[<![endif]]]></xsl:comment>
 </div>
 </body>
 </html>



That should restore the download pages, but will revert the IE8 fixes.

Regards,
Konstantin Preißer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message