tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy (*$^¨%`£) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings
Date Fri, 16 Aug 2013 11:57:48 GMT

    [ https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13742130#comment-13742130
] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-177:
------------------------------------------------

I wonder how you generate the patch?

Trying to apply it give me:

mb-olamy:tomcat-maven-plugin olamy$ git apply MTOMCAT-177.patch 
fatal: patch fragment without header at line 3: @@ -34,12 +34,14 @@ import org.apache.http.client.methods.HttpGet;
mb-olamy:tomcat-maven-plugin olamy$ patch -p0 < MTOMCAT-177.patch 
missing header for unified diff at line 3 of patch
(Stripping trailing CRs from patch.)
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
| common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java

|index e9e2b84..dc2be06 100644
--------------------------
File to patch: common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java

patching file common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
patch: **** malformed patch at line 72: 

BTW I find this a bit odd

+    /**
+     * @param proxy
+     */
+    public void setProxy(Proxy proxy) {
+		if( this.proxy != proxy ) {
+			this.proxy = proxy;
+			if( httpClient != null ) {
+				applyProxy();
+			}
+		}
+	}
+    

why not a simple method configureProxy(Proxy proxy)?
WDYT?


                
> tomcat7:deploy ignores proxy settings
> -------------------------------------
>
>                 Key: MTOMCAT-177
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-177
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Bug
>          Components: tomcat7
>    Affects Versions: 2.0
>            Reporter: Brad Larson
>            Assignee: Olivier Lamy (*$^¨%`£)
>              Labels: proxy
>         Attachments: MTOMCAT-177.patch
>
>
> Using these settings:
> <groupId>org.apache.tomcat.maven</groupId>
> <artifactId>tomcat7-maven-plugin</artifactId>
> <version>2.0-SNAPSHOT</version>
> When running tomcat7:deploy behind a network proxy (specified in ~/.m2/settings.xml),
the deploy will fail with a very generic error message.  Running outside of the proxy (with
no proxy settings in ~/.m2/settings.xml) works fine.
> The error message is simply "Connection refused", no other details provided.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message