tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: svn commit: r1518225 - /tomcat/native/branches/1.1.x/native/src/network.c
Date Thu, 29 Aug 2013 20:36:27 GMT
Rainer,

On 8/29/13 1:23 PM, Rainer Jung wrote:
> On 28.08.2013 16:52, schultz@apache.org wrote:
>> Author: schultz
>> Date: Wed Aug 28 14:52:00 2013
>> New Revision: 1518225
>>
>> URL: http://svn.apache.org/r1518225
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51813
>>
>> Add NULL-checking for s->net to avoid SIGSEGV in situations where it appears a
socket has been recycled.
>>
>> Modified:
>>     tomcat/native/branches/1.1.x/native/src/network.c
> 
> If it is straightforward you might also want to apply to tcnative trunk
> to reduce code drift. I know tcnative trunk is not in good shape but still.

I'm happy to see if the patch will merge (somewhat) cleanly.

In either case, the patch was fairly simple if I had to re-do the whole
thing from scratch... it's just NULL checking :)

-chris


Mime
View raw message