Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.214.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20130712132504.E909423888D7@eris.apache.org>
References: <20130712132504.E909423888D7@eris.apache.org>
Date: Sat, 13 Jul 2013 03:49:35 +0400
Message-ID: 
 <CABzHfVkm+uPCtUZeBVTqPkF-ssw8vx7q-NU2=F9CsO61EP0h5g@mail.gmail.com>
Subject: Re: svn commit: r1502552 - in /tomcat/trunk:
 java/javax/el/ELProcessor.java
 test/javax/el/TestELProcessor.java
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

2013/7/12  <markt@apache.org>:
> Author: markt
> Date: Fri Jul 12 13:25:04 2013
> New Revision: 1502552
>
> URL: http://svn.apache.org/r1502552
> Log:
> Add some more unit tests for the EL processor and make sure it uses the import information it has to hand to resolve class names.
>
> Modified:
>     tomcat/trunk/java/javax/el/ELProcessor.java
>     tomcat/trunk/test/javax/el/TestELProcessor.java
>
> Modified: tomcat/trunk/java/javax/el/ELProcessor.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ELProcessor.java?rev=1502552&r1=1502551&r2=1502552&view=diff
> ==============================================================================
> --- tomcat/trunk/java/javax/el/ELProcessor.java (original)
> +++ tomcat/trunk/java/javax/el/ELProcessor.java Fri Jul 12 13:25:04 2013
> @@ -74,7 +74,12 @@ public class ELProcessor {
>                      context, "elProcessor.defineFunctionNullParams"));
>          }
>
> -        Class<?> clazz = Class.forName(className);
> +        // Check the imports
> +        Class<?> clazz = context.getImportHandler().resolveClass(className);
> +
> +        if (clazz == null) {
> +            clazz = Class.forName(className);
> +        }

Is it supposed to be able to load classes that belong to a web application?
If so, then you need TCCL here.

Class.forName(className) will only load classes from Common
classloader (where javax.el.ELProcessor is loaded from).

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org