tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 55159] Wasted work in ErrorReportValve.getPartialServletStackTrace
Date Mon, 01 Jul 2013 10:37:25 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=55159

--- Comment #2 from Violeta Georgieva <violetagg@apache.org> ---
(In reply to Adrian Nistor from comment #0)
> The above fix (in patch.diff) is certainly correct (it's easy to see
> through code inspection), but I think we can have an even shorter
> patch (one line, in patchShort.diff): just break as soon as "pos" is
> set, without reversion the loop order.  patchShort.diff is correct
> only if there can be only one "elements[i]" with class name
> "org.apache.catalina.core.ApplicationFilterChain" and method name
> "internalDoFilter" or if it doesn't matter which such "elements[i]" is
> detected (the last, like in the original code, or the first, like in
> patchShort.diff).

We need the last element and not the first one. So the first patch is the
proper one.

Regards
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message