tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Various shell-scripting idioms in bin/daemon.sh
Date Thu, 18 Jul 2013 12:28:19 GMT
On 18 July 2013 10:13, Rainer Jung <rainer.jung@kippdata.de> wrote:
> On 18.07.2013 06:04, Mladen Turk wrote:
>> On 07/17/2013 11:59 PM, sebb wrote:
>>> Regardless, please consider documenting the script to explain why it
>>> does not use -n/-z if that is necessary to avoid bugs.
>>>
>>
>> It would be the same as documenting why one uses a+=1 instead a++ :)
>> I don't see where its written that one *must* use -n/-z at the first place.
>
> Coming from SunOS 4 times I agree. That "X$var" comparing with "Xvalue"
> idiom is or at least was very common in system shell scripts. No need to
> document, that is just practical shell language programming knowledge.

I'm willing to accept that; though I think the use of . is not ideal.

> The same to not using "-n" or "-z" for platform independent shell
> script. It seems to me that POSIX and the later Unix standards still do
> not standardize the allowed shell expression syntax. There is a standard
> "test" commandline util, but IMHO that's not the same.

This is different, because for many, using -n or -z is going to be
common practise.
If it's important *not* to use them here, then it should be documented why.

Clearly the OP did not know why -n and -z were not used.
Please let future maintainers know.

> Regards,
>
> Rainer
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message