tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Violeta Georgieva <>
Subject Couple of question about javax.el.BeanELResolver
Date Thu, 11 Jul 2013 12:49:40 GMT

I have the following question about:

1. Method setValue
There is some mismatch in the javadoc. In the method description there is
the following statement:

"If the property exists but does not have a setter, then a
PropertyNotFoundException is thrown."

But the throws clause states:

"PropertyNotWritableException - if this resolver was constructed in
read-only mode, or if there is no setter for the property."

Our implementation currently throws PropertyNotFoundException.
I'm going to change it to throw PropertyNotWritableException.
What do you think?

Also I'm going to report a bug for this against the spec.

2. Method isReadOnly
There is not explicit statement what should be returned in case
base/property are null.
However there is statement that:

"If this resolver was constructed in read-only mode, this method will
always return true."

What do you think about this change:

@@ -195,7 +195,7 @@
             throw new NullPointerException();
         if (base == null || property == null) {
-            return false;
+            return readOnly;

         context.setPropertyResolved(base, property);


  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message