tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremy Boynes <jboy...@apache.org>
Subject Re: svn commit: r1507870 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappServiceLoader.java
Date Mon, 29 Jul 2013 20:56:44 GMT
On Mon, Jul 29, 2013 at 9:51 AM, Mark Thomas <markt@apache.org> wrote:

> On 29/07/2013 01:01, jboynes@apache.org wrote:
> > Author: jboynes
> > Date: Sun Jul 28 23:01:23 2013
> > New Revision: 1507870
> >
> > URL: http://svn.apache.org/r1507870
>
> Generally, line lengths should be limited to 80 characters. I know not
> all of the Tomcat code does that but new code should.
>

I'll set up style rules and fix that.


>
>
> > +public class WebappServiceLoader<T> {
> > +    private static final String LIB = "/WEB-INF/lib/";
> > +    private static final String SERVICES = "META-INF/services/";
> > +    private static final Charset UTF8 = Charset.forName("UTF-8");
>
> Should use B2CConverter.UTF_8
>

I try to avoid dependencies and this would be the same instance from
Charset's cache so I don't see any memory benefit. Am I missing something
here?

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message