tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremy Boynes <jboy...@apache.org>
Subject Re: [Bug 55245] Add test cases for JspC
Date Fri, 12 Jul 2013 16:19:22 GMT
On Jul 12, 2013, at 1:46 AM, bugzilla@apache.org wrote:

> https://issues.apache.org/bugzilla/show_bug.cgi?id=55245
> 
> --- Comment #3 from Mark Thomas <markt@apache.org> ---
> It is worth noting that this new test case fails and that this is expected as
> it highlights at least one bug (bug 55250) in the refactored JspC code.
> 
> I've added this locally but will refrain from committing it until the tests
> pass.
> 
> As an aside, what is wrong with the JSPO syntax in the test for 47331?

47331 is about Tomcat not returning an error if a JSP illegally has deferred syntax embedded.
The test JSP deliberately has such a syntax error and the test case looks for a 500 response
from the server. JspC also detects that error and aborts the compilation run.

One option would be to move that type of negative test into a different webapp. Perhaps better
long term would be to have JspC continue whilst accumulating errors so we can test both types
of outcome at the end.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message