tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeremy Boynes <jboy...@apache.org>
Subject Re: Jasper improvements - web resources and TLDs
Date Sun, 21 Jul 2013 17:36:00 GMT
On Jul 8, 2013, at 12:23 AM, Mark Thomas <markt@apache.org> wrote:
> On 08/07/2013 06:38, Jeremy Boynes wrote:
>> 
>> Another area of convergence is in parsing TLDs: currently both
>> Catalina and Jasper do it, differently.
> 
> A lot of the code is identical with large comments to keep the two
> implementations in sync.
> 
>> I believe Catalina only reads
>> them to detect the Listeners they define and if that's the case we
>> could perhaps add a SCI to Jasper that handled all TLD functionality
>> including registering the listeners programmatically (at least that's
>> what Servlet 8.3 implies).
> 
> Agreed.
> 
>> That would remove Catalina's dependency
>> on web-jsptaglibrary*.xsd and on TLD-related classes. To support
>> validation though we would need to add the XSD-based validation in
>> Jasper.
> 
> This is beginning to get far enough away from where the code is right
> now that I'd suggest just noting the issue and come back to it when the
> other changes are complete.

With r1505235 JspC is now merging in <jsp-config> from web fragments. It is still not
handling resources found in those jars e.g. if they are referenced by an include directive
or from a prelude/coda configuration. This should be handled through the ServletContext so
I'd suggest approaching it using the new webresource support. However, that has dependencies
on Catalina (e.g. Lifecycle) that JspC would not need - how hard would that be to decouple?

In the meantime, I'm going to look at refactoring the TLD support as described above.

Cheers
Jeremy


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message