tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1501719 - in /tomcat/trunk: java/javax/el/ResourceBundleELResolver.java test/javax/el/TestResourceBundleELResolver.java
Date Wed, 10 Jul 2013 11:34:10 GMT
On 10/07/2013 12:11, violetagg@apache.org wrote:
> Author: violetagg
> Date: Wed Jul 10 11:11:23 2013
> New Revision: 1501719
> 
> URL: http://svn.apache.org/r1501719
> Log:
> javax.el.ResourceBundleELResolver:
> According to javadoc:
> 1. When creating FeatureDescriptors shortDescription must be empty string
> 2. isReadOnly returns true only if the base is instance of ResourceBundle
> Unit tests are added

No objection to the commit but I am going to be picky. It doesn't matter
in this case but there might be other cases where it does - hence why I
want to highlight this issue.

With reference to point 2 in the commit message, the specification
language doesn't say that exactly.

It states:
<quote>
If the base object is not null and an instanceof ResourceBundle, return
true.
...
Returns: if the propertyResolved property of ELContext was set to true,
then true; otherwise undefined.
</quote>

If the first sentence in the quote above was "If and only if the
base..." then point 2 in the commit message would be valid.

Since the return value is undefined if the propertyResolved property is
not set then this commit doesn't break the spec - hence my lack of
objection to it.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message