Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D8228102F1 for ; Tue, 4 Jun 2013 12:41:43 +0000 (UTC) Received: (qmail 70770 invoked by uid 500); 4 Jun 2013 12:41:40 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 70416 invoked by uid 500); 4 Jun 2013 12:41:40 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 70406 invoked by uid 99); 4 Jun 2013 12:41:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 12:41:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 12:41:37 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id 669909C4B; Tue, 4 Jun 2013 12:41:17 +0000 (UTC) From: bugzilla@apache.org To: dev@tomcat.apache.org Subject: [Bug 55054] public method exitWhenFinished() removed from FileCleaningTracker. Date: Tue, 04 Jun 2013 12:41:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Tomcat 7 X-Bugzilla-Component: Catalina X-Bugzilla-Version: trunk X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: markt@apache.org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@tomcat.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=55054 Mark Thomas changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Mark Thomas --- (In reply to Mark Jeffcoat from comment #0) > The March 15 commit "Update to Commons IO 2.4 and run UCDetector over the > copied classes" removed FileCleaningTracker.exitWhenFinished(), presumably > by accident. It was deliberate, not accidental. > This makes it difficult to stop the reaper thread, which leads to memory > leaks. There is no reaper thread. (More code that can be removed. Removal of unused code is often an iterative process.) > I believe this is an error (by the UCDetector?): Commons IO 2.4 does have > this method, and the FileCleaningTracker Javadocs still refer to it. As above, this was deliberate. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org