Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B5CE100D5 for ; Wed, 12 Jun 2013 20:08:32 +0000 (UTC) Received: (qmail 92891 invoked by uid 500); 12 Jun 2013 20:08:31 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 92832 invoked by uid 500); 12 Jun 2013 20:08:31 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 92823 invoked by uid 99); 12 Jun 2013 20:08:31 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2013 20:08:31 +0000 Received: from localhost (HELO [192.168.23.9]) (127.0.0.1) (smtp-auth username markt, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2013 20:08:31 +0000 Message-ID: <51B8D539.9040706@apache.org> Date: Wed, 12 Jun 2013 21:08:25 +0100 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r1492331 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/startup/ test/org/apache/catalina/core/ test/org/apache/catalina/... References: <20130612183132.40DA823889ED@eris.apache.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 12/06/2013 20:43, Konstantin Kolinko wrote: > 2013/6/12 : >> Author: markt >> Date: Wed Jun 12 18:31:30 2013 >> New Revision: 1492331 >> >> URL: http://svn.apache.org/r1492331 >> Log: >> With clarification from the EG for Servlet 3.1 section 4.4 finally makes sense. Implement the necessary restriction and add a test case. >> >> Added: >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/deploy/ApplicationListener.java >> - copied unchanged from r1492307, tomcat/trunk/java/org/apache/catalina/deploy/ApplicationListener.java >> tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TesterTldListener.java >> - copied unchanged from r1492307, tomcat/trunk/test/org/apache/catalina/core/TesterTldListener.java >> tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/listener.tld >> - copied unchanged from r1492307, tomcat/trunk/test/webapp-3.0/WEB-INF/listener.tld >> Modified: >> tomcat/tc7.0.x/trunk/ (props changed) >> tomcat/tc7.0.x/trunk/java/javax/servlet/ServletContext.java >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/Context.java >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/deploy/WebXml.java >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/FailedContext.java >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/TldConfig.java >> tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/WebAnnotationSet.java >> tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java >> tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestNamingContextListener.java >> tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestStandardContext.java >> tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TesterContext.java >> tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TestListener.java >> > > 1. Do not forget to update the changelog. Ack. > 2. Looking at update of javadoc in j.s.ServletContext java, > > Why is there restriction for getEffectiveMajorVersion(), > getEffectiveMinorVersion() methods? > > They are not used for programmatic configuration of > servlets/filters/listeners and they are not mentioned in Chapter 4.4, > so I think there should not be such restriction on calling them. You might think that. I might agree. However, the Servlet 3.0 Javadoc says there should be a restriction. > 3. You changed a method in o.a.c.Context. We usually add methods > there, but do not change the existing ones. Yes, I did. Drat. I put some text in the release notes saying that I wouldn't do that. I'll fix that. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org