Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Message-ID: <51ADE554.4060401@apache.org>
Date: Tue, 04 Jun 2013 14:02:12 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: AsyncContext.dispatch(path) invoked more than once
References: 
 <CAFmzfTUcAs=urfORwiHYE+r8rgSkd3uQNywvV09X2p8-0LK_RA@mail.gmail.com>
 <CABzHfV==jqEnX-DA_U_hp2uOfP5rgfRikXaKKkiEoX9b8NC+Pw@mail.gmail.com>
 <CAFmzfTWs+g-TFNtCxyhQa+Di-XfTuoOG50aUX-B9Jz3JvQ+oZQ@mail.gmail.com>
 <CAFmzfTWkPauqueuP_M6Vf1nU7zEMcFiLFxAaAZepYpHzrNm_Pg@mail.gmail.com>
 <CAFmzfTVpXo8qr7yMY1+rSXCdO=Lw8yTBYGjKru7yHnEZtHog_A@mail.gmail.com>
In-Reply-To: 
 <CAFmzfTVpXo8qr7yMY1+rSXCdO=Lw8yTBYGjKru7yHnEZtHog_A@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 04/06/2013 13:55, Violeta Georgieva wrote:
> 2013/5/31 Violeta Georgieva wrote:

>> Let's put this as plan B for now.
>>
>> I made a small change in the AsyncContextImpl.doInternalDispatch().
>>
>> Can you comment on the patch?
>>
>>
>> Index: C:/tc8.0.x/java/org/apache/catalina/core/AsyncContextImpl.java
>> ===================================================================
>> --- C:/tc8.0.x/java/org/apache/catalina/core/AsyncContextImpl.java
> (revision 1488110)
>> +++ C:/tc8.0.x/java/org/apache/catalina/core/AsyncContextImpl.java
> (working copy)
>> @@ -185,6 +185,10 @@
>>              logDebug("dispatch   ");
>>          }
>>          check();
>> +        if (dispatch != null) {
>> +            throw new IllegalStateException(
>> +                    sm.getString("asyncContextImpl.dispatchingStarted"));
>> +        }
>>          if (request.getAttribute(ASYNC_REQUEST_URI)==null) {
>>              request.setAttribute(ASYNC_REQUEST_URI,
> request.getRequestURI());
>>              request.setAttribute(ASYNC_CONTEXT_PATH,
> request.getContextPath());
>> @@ -347,7 +351,9 @@
>>              logDebug("intDispatch");
>>          }
>>          try {
>> -            dispatch.run();
>> +            Runnable runnable = dispatch;
>> +            dispatch = null;
>> +            runnable.run();
>>              if (!request.isAsync()) {
>>                  fireOnComplete();
>>              }
>>
>>
> 
> Can you comment?

Looks good to me.

> Any other suggestions?

Nope :)

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org