tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niki Dokovski <nick...@gmail.com>
Subject Re: [Bug 55006] Add http proxy support for ClientEndpoint using system properties
Date Mon, 03 Jun 2013 14:27:55 GMT
On Mon, Jun 3, 2013 at 3:44 PM, Niki Dokovski <nickytd@gmail.com> wrote:

>
>
>
> On Mon, Jun 3, 2013 at 3:13 PM, <bugzilla@apache.org> wrote:
>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55006
>>
>> --- Comment #3 from Konstantin Kolinko <knst.kolinko@gmail.com> ---
>> (In reply to Mark Thomas from comment #2)
>> > Generally, I dislike using system properties for any kind of
>> configuration.
>>
>> I do as well.
>>
>> How about using ClientEndpointConfig.getUserProperties() to pass those?
>>
>
> +1
> In general, I'm fine with any proposal that removes the limitation. Just
> hope that JSR 356 EG won't wait for Java EE 8 to come up with an update.
>  Meanwhile people can use current patch. Or we can craft something based on
> user configurations in ClientEndpoint leveraging Mark's ProxySelector. I'll
> give it a try...
>
> cheers
>

At first look,  It turned to be a bit challenging of how to get to the
modifiable user properties map if you work only with annotated class.

Just created another bug for the spec. (The javadoc in one of the
connectToServer methods should be changed as it states that the supplied
object should be annotated with ServerEndpoint where it actually should be
annotated with ClientEndpoint.
https://java.net/jira/browse/WEBSOCKET_SPEC-206


Further on, if you choose to use connectToServer call that has the
ClientEndpointConfig param you are losing the annotation approach as the
first param of this call has to be an instance of an Endpoint. Hence your
class can not be just annotated. hmmm Mark where can we bring this
discussion?




>
>> --
>> You are receiving this mail because:
>> You are the assignee for the bug.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message