tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caldarale, Charles R" <Chuck.Caldar...@unisys.com>
Subject RE: APR/native errors with non-blocking I/O
Date Mon, 03 Jun 2013 12:54:02 GMT
> From: Mark Thomas [mailto:markt@apache.org] 
> Subject: Re: APR/native errors with non-blocking I/O

> I'm thinking something along the lines of the following:

> if (ss == APR_SUCCESS)
>     return (jint)sent;
> else if ((APR_STATUS_IS_EAGAIN(ss) || ss == TCN_EAGAIN)  && sent > 0) {
>     return (jint)sent;
> } else {
>     TCN_ERROR_WRAP(ss);
>     return -(jint)ss;
> }

Looks reasonable - just get rid of the else keywords, since each condition ends with a return.

 - Chuck


THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus
for use only by the intended recipient. If you received this in error, please contact the
sender and delete the e-mail and its attachments from all computers.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message