tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Burch <br...@pingtoo.com>
Subject Re: svn commit: r1492563 - in /tomcat/tc7.0.x/trunk: ./ build.properties.default build.xml modules/jdbc-pool/build.properties.default modules/jdbc-pool/build.xml webapps/docs/changelog.xml
Date Thu, 13 Jun 2013 15:28:51 GMT
On 13/06/13 13:57, Konstantin Kolinko wrote:
> 2013/6/13 Brian Burch <brian@pingtoo.com>:
>> Sorry, but I cannot quote the relevant section of the original email because
>> I had already deleted my copy.
>>
>> This commit replaces the dependency on junit 4.8.2 with 4.11. It causes
>> collateral damage to the current version of netbeans support. It is on my
>> todo list to come up with a less fragile solution, but in the meantime could
>> someone please commit the following change on my behalf?
>>
>> brian@schizo:~/sandboxApache/tomcat8/trunk$ svn diff
>> Index: res/ide-support/netbeans/project.xml
>> ===================================================================
>> --- res/ide-support/netbeans/project.xml        (revision 1492631)
>> +++ res/ide-support/netbeans/project.xml        (working copy)
>> @@ -189,9 +189,9 @@
>>               <compilation-unit>
>>                   <package-root>test</package-root>
>>                   <unit-tests/>
>> -                <classpath
>> mode="compile">output/classes:output/testclasses:${base.path}/junit4.8.2/junit-4.8.2.jar</classpath>
>> +                <classpath
>> mode="compile">output/classes:output/testclasses:${base.path}/junit-4.11/junit-4.11.jar</classpath>
>>                   <source-level>1.7</source-level>
>>               </compilation-unit>
>>           </java-data>
>>       </configuration>
>> -</project>
>> \ No newline at end of file
>> +</project>
>>
>
> Done.
> http://svn.apache.org/r1492647
>
> BTW,  nb-tomcat-project.properties  file contains:
> ant.includes= ... ${ant.home}/lib/junit.jar
>
> Does one really need that copy of JUnit jar?
> There is no junit.jar file in my copy of Ant 1.9.1.

That is a good point, so thanks for pointing it out. I have just 
discovered that my copy was installed as part of the 1.8.2 ant-optional 
debian package.

I need to take a long, thoughtful look at junit specifically. The 
situation is particularly tricky because it needs to used consistently:
a) under command-line ant builds for tomcat8, but not necessarily for 
other projects.
b) under the netbeans source editor syntax checker for tomcat8, but not 
for other projects (netbeans ships with its own copy of junit).
c) when building, executing or debugging tomcat8 under netbeans, which 
uses its own copy of ant to run my nb-project.xml targets that, in turn, 
run the tomcat8 ant targets.

I know I currently have some problems in this area, e.g. my own netbeans 
is not intercepting tomcat8's junit results to be graphically presented 
on the workbench.

(I feel there isn't a lot I can learn by looking at the way eclipse 
works, but I hardly ever use it so can't be sure.)

>> BTW.. I don't understand the "no newline" warning - I tried my diff against
>> new copies with and without a trailing newline, but got the message in both
>> cases.
>
> It is just an information message, as otherwise the textual diff
> format cannot show the difference differentiate between missing and
> present newline on the last line of a file.
>
> As the message is just after '-' and before '+' it means that the old
> file ends with '</project>' character without any trailing newline.
> It might be that your text editor adds one.
>
> For XML files the presence of a newline at the end of the file does not matter.

That is good to know. I wanted to ensure this initial release of 
netbeans support did not have any nasty style problems that might be 
carried forward into future changes. (e.g. I wondered whether this might 
be an svn property issue.) I will stop worrying!

> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message