tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Burch <br...@pingtoo.com>
Subject Re: svn commit: r1492647 - in /tomcat/trunk/res/ide-support/netbeans: nb-tomcat-build.properties project.xml
Date Thu, 13 Jun 2013 14:54:19 GMT
On 13/06/13 13:44, kkolinko@apache.org wrote:
> Author: kkolinko
> Date: Thu Jun 13 12:44:30 2013
> New Revision: 1492647
>
> URL: http://svn.apache.org/r1492647
> Log:
> Update JUnit version in NetBeans files.
> Hamcrest library is now in its own jar.
>
> Modified:
>      tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties
>      tomcat/trunk/res/ide-support/netbeans/project.xml
>
> Modified: tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties
> URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties?rev=1492647&r1=1492646&r2=1492647&view=diff
> ==============================================================================
> --- tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties (original)
> +++ tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties Thu Jun 13 12:44:30
2013
> @@ -37,7 +37,7 @@ nb-test.io-method=org.apache.coyote.http
>   # it is not possible to retrieve the classpaths from the build to
>   # use in the NetBeans targets, so they must be explicitly declared
>
> -nb-test.classpath=${test.classes}:${tomcat.build}/webapps/examples/WEB-INF/classes:${base.path}/junit4.8.2/junit-4.8.2.jar:${base.path}/ecj-4.2.2/ecj-4.2.2.jar:${tomcat.classes}
> +nb-test.classpath=${test.classes}:${tomcat.build}/webapps/examples/WEB-INF/classes:${base.path}/junit-4.11/junit-4.11.jar:${base.path}/hamcrest-1.3/hamcrest-core-1.3.jar:${base.path}/ecj-4.2.2/ecj-4.2.2.jar:${tomcat.classes}
>
>   # Extra properties used by the Tomcat project additional NetBeans targets.
>
>
> Modified: tomcat/trunk/res/ide-support/netbeans/project.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/netbeans/project.xml?rev=1492647&r1=1492646&r2=1492647&view=diff
> ==============================================================================
> --- tomcat/trunk/res/ide-support/netbeans/project.xml (original)
> +++ tomcat/trunk/res/ide-support/netbeans/project.xml Thu Jun 13 12:44:30 2013
> @@ -189,7 +189,7 @@
>               <compilation-unit>
>                   <package-root>test</package-root>
>                   <unit-tests/>
> -                <classpath mode="compile">output/classes:output/testclasses:${base.path}/junit4.11/junit-4.11.jar</classpath>
> +                <classpath mode="compile">output/classes:output/testclasses:${base.path}/junit-4.11/junit-4.11.jar:${base.path}/hamcrest-1.3/hamcrest-core-1.3.jar</classpath>
>                   <source-level>1.7</source-level>
>               </compilation-unit>
>           </java-data>
>

Thanks, Konstantin!

I had noticed the arrival of an explicit dependency on hamcrest when we 
moved to junit 4.11, but because I didn't know why I decided to only 
include the new junit jar in the netbeans source classpath.

I have just read 
http://stackoverflow.com/questions/5569394/how-to-use-junit-and-hamcrest-together, 
and can see the full explanation (including the fact that complications 
associated with junit-dep.jar have gone away with 4.11).

I now understand that your change was necessary to avoid netbeans 
flagging syntax errors on some test classes.

>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message