tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Where to put proposals for tcnative?
Date Thu, 06 Jun 2013 17:56:54 GMT
Rainer,

On 6/6/13 1:32 PM, Rainer Jung wrote:
> On 06.06.2013 18:22, Christopher Schultz wrote:
>> All,
>>
>> Neither tcnative/trunk not tcnative/branches/1.1.x have a STATUS.txt
>> file... where should proposals be made? In Tomcat directly?
> 
> The Java classes come from TC trunk via externals. So proposals which
> are mainly for those can be discussed just like any big trunk change
> (mail list).
> 
> Proposals mostly for the C files probably make sense in a STATUS file
> here if they are backports from native trunk.

I was going to make a C-language proposal.

I can't seem to get "configure" to work in trunk because some macros
aren't working properly (see below), so I've been working in the 1.1.x
branch.

> The old STATUS file can be seen under:
> 
> http://svn.apache.org/viewvc?view=revision&revision=881756
> 
> Proposals for the C part in native trunk probably also make sense to
> discuss on the mail list if necessary.

The patch in question is the one attached to this bug:

https://issues.apache.org/bugzilla/show_bug.cgi?id=51813

Normally, I'd just make the change and let someone object, but tcnative
is something I have less familiarity with, so I wanted to get some eyes
on it (probably Mladen's) before committing.

Thanks,
-chris

PS Here's what I get when trying to build tcnative-trunk:

$ sh buildconf --with-apr=../../apr-1.4.6/

Looking for apr source in ../../apr-1.4.6/
Creating configure ...
Generating 'make' outputs ...
rebuilding rpm spec file

./configure --with-apr=../../apr-1.4.6/ --with-ssl=yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking for working mkdir -p... yes
Tomcat Native Version: 1.2.0
checking for chosen layout... tcnative
checking for APR... yes
configure: APR 1.4.6 detected.
  setting CC to "gcc"
  setting CPP to "gcc -E"
./configure: line 2710: TCN_FIND_JDK: command not found
./configure: line 2711: TCN_SABLEVM: command not found
./configure: line 2712: TCN_J9VM: command not found
  adding "-I/usr/include" to TCNATIVE_PRIV_INCLUDES
checking for JDK os include directory... Cannot find jni_md.h in /usr/
configure: error: You should retry --with-os-type=SUBDIR

It looks like configure only looks at JAVA_HOME environment variable and
does not accept --with-java-home like tcnative 1.1.x does.

I think we should allow --with-java-home like tcnative 1.1.x, but I have
no idea how to work with buildconf/configure/etc.


Mime
View raw message