tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: APR/native errors with non-blocking I/O
Date Mon, 03 Jun 2013 13:33:14 GMT
On 03.06.2013 14:54, Caldarale, Charles R wrote:
>> From: Mark Thomas [mailto:markt@apache.org] 
>> Subject: Re: APR/native errors with non-blocking I/O
> 
>> I'm thinking something along the lines of the following:
> 
>> if (ss == APR_SUCCESS)
>>     return (jint)sent;
>> else if ((APR_STATUS_IS_EAGAIN(ss) || ss == TCN_EAGAIN)  && sent > 0)
{
>>     return (jint)sent;
>> } else {
>>     TCN_ERROR_WRAP(ss);
>>     return -(jint)ss;
>> }
> 
> Looks reasonable - just get rid of the else keywords, since each condition ends with
a return.

+1

I guess this is for sendb and also sendbb?

Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message