Return-Path: 
 <dev-return-138566-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org>
X-Original-To: apmail-tomcat-dev-archive@www.apache.org
Delivered-To: apmail-tomcat-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EA6A6DDF7
	for <apmail-tomcat-dev-archive@www.apache.org>;
 Mon, 20 May 2013 11:16:31 +0000 (UTC)
Received: (qmail 8721 invoked by uid 500); 20 May 2013 11:16:31 -0000
Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org
Received: (qmail 8517 invoked by uid 500); 20 May 2013 11:16:31 -0000
Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@tomcat.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@tomcat.apache.org>
List-Post: <mailto:dev@tomcat.apache.org>
List-Id: <dev.tomcat.apache.org>
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Delivered-To: mailing list dev@tomcat.apache.org
Received: (qmail 8488 invoked by uid 99); 20 May 2013 11:16:30 -0000
Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 May 2013 11:16:30 +0000
Received: from localhost (HELO [192.168.23.9]) (127.0.0.1)
  (smtp-auth username markt, mechanism plain)
  by minotaur.apache.org (qpsmtpd/0.29) with ESMTP;
 Mon, 20 May 2013 11:16:29 +0000
Message-ID: <519A060A.5090709@apache.org>
Date: Mon, 20 May 2013 12:16:26 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r1484409 - in /tomcat/trunk: ./
 res/ide-support/netbeans/
 webapps/docs/
References: <20130520095326.0CF5D23888E3@eris.apache.org>
 <5199F801.9050300@pingtoo.com>
In-Reply-To: <5199F801.9050300@pingtoo.com>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 20/05/2013 11:16, Brian Burch wrote:
> On 20/05/13 10:53, markt@apache.org wrote:
>> Author: markt
>> Date: Mon May 20 09:53:25 2013
>> New Revision: 1484409
>>
>> URL: http://svn.apache.org/r1484409
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54899
>> Provide an initial implementation of NetBeans support.
>> Patch provided by Brian Burch.
>>
>> Added:
>>      tomcat/trunk/res/ide-support/netbeans/
>>      tomcat/trunk/res/ide-support/netbeans/README   (with props)
>>     
>> tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties  
>> (with props)
>>     
>> tomcat/trunk/res/ide-support/netbeans/nb-tomcat-project.properties  
>> (with props)
>>      tomcat/trunk/res/ide-support/netbeans/nb-tomcat.xml   (with props)
>>      tomcat/trunk/res/ide-support/netbeans/project.xml   (with props)
> <snip/>
> 
> Thanks very much Mark - I now have a sensible base on which to explore
> further improvements.
> 
> BTW.. I tried to preserve the implicit and explicit NetBeans copyright
> notices on its auto-generated templates, while adding suitable
> copyrights for the new apache content... did you conclude that my
> amateur attempts were good enough? Simply passing our primitive code
> style checks is probably not good enough!

I don't see any copyright notices. I don't see any license headers either.

I do see a section that looks similar to our NOTICE file.

These files appear to be auto-generated based on input you have
provided. The only content I'm concerned about are the comments. Are
they all yours? If so, I'll just remove the NetBeans notice. If not,
we'll need to remove any comments that aren't yours and the notice.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org