Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Message-ID: <519097CE.10700@apache.org>
Date: Mon, 13 May 2013 08:35:42 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130328 Thunderbird/17.0.5
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: Automatic deployment changes
References: <5188F99F.60206@apache.org>
 <51896086.1050108@christopherschultz.net> <51896C9A.3020300@apache.org>
 <518A5EA0.8050103@christopherschultz.net>
In-Reply-To: <518A5EA0.8050103@christopherschultz.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/05/2013 15:18, Christopher Schultz wrote:

> Perhaps I should clarify my question with an example: what happens 
> when a WAR file is found and a DIR also exists with the same 
> context name, but expandWars is false? Does the directory get 
> updated with the contents of the WAR file, or does the WAR's 
> descriptor control the deployment (subject to all the other 
> behavior covered by your table(s)) and then (potentially old) 
> content is served from the pre-existing DIR?

Ah. One of the edge cases that makes this rather more complex than it
first appears.

There are a couple of ways to get Tomcat into this state. They ways I
can think of are:
a) deploy the WAR then copy the DIR
b) deploy the DIR, stop Tomcat, copy the WAR, start Tomcat

There may be others.

Note for case b) if Tomcat is running, the DIR will be removed.

In both cases what should happen is that the content is served from
the WAR and the DIR is ignored. The question is what happens when the
WAR is removed? Is the DIR removed as well? Alternatively, should the
DIR be removed as soon as it is detected?

I'm leaning towards the DIR just being ignored but a warning logged.
That would mean:
- - Content is served from the WAR
- - The DIR remains but is unused
- - A warning will be logged when the DIR is first detected
- - If the WAR is removed, the DIR will be deployed

There are similar questions about what happens if you have XML +
WAR(external) + DIR (expanded) and you add a WAR to the appBase?
Again, I'm leaning towards ignoring it apart from a warning when it is
first detected.

I've updated the proposal to cover these.

Mark

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRkJfOAAoJEBDAHFovYFnnyLEP/0YfRnWUSY2zq3HTDmDr/s7/
VQZdLJS1A2urUK0yOYPOYufZAwhzA1lqmdOIIG4rQ6755kA3ppjV/Zl2knHduG0N
x0VxF+JYmKVeu9W30vZyXrwAf3zC9PMD6etWCgd8wlOaeedJpnPfiq3vBCMBE8nV
8t0tebNjNEbxm7pJhoyZAvNhQXuiWLP2NpNY91Mxwky2bOLRKUQBKbhUJb5ye+0z
shN4YxG1sOKsjLf58Ktd+4Ur6JwSIyPpOV0c5625N1ihesR1VGAmu31mliwX3EBP
7pKph/BPEBXJTf6IBFmkArAePprPNXbD+NgocZuGeLB0on2KjHNIoeh6GxpSa1F1
3HfUJq1npeGEis051AHngsCqn62xfpQQzLm9CTLJNjug0DXgMxkgzKD99c1cS7GM
11ijfDHykqJfYfcL5pMuW9CfdlNCSFN4jTuAE4MCzCkKBJZ6cod44lN4l/527Xkr
cKDhkE+14r/rHUoCpIPuXh3YeX9F4EH2AN+/P3TAOiATVS8/QZUHWhKltKfqzgRm
x2TrOpbpc81IHSOxvJSxaVNx/0b2rXnd3Ow6cuz52LR8anBMsW0lrVDlvQMPpclA
Tt66Bn8CVxSPQFWccKq2h/twF9HXJih4auGKNiJG7GibmoNGPuTYFyrzB3sy7b1V
4tpkpkZPEs4QrE83Zvu4
=SSAJ
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org