tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Björn Raupach <raup...@me.com>
Subject [PATCH] jdbc-pool | FairBlockingQueue
Date Fri, 24 May 2013 20:08:18 GMT
Hello,

out of pure curiosity I was browsing the source of jdbc-pool and ended up looking through
FairBlockingQueue. FairBlockingQueue utilises a global ReentrantLock for mutual exclusion.
Common practice is to always follow a call to lock with a try-finally block. The methods poll(long,
TimeUnit), pollAsync() don't use that practice. I was wondering why. Attached is modified
version of FairBlockingQueue. I know FairBlockingQueue is a sensitive part of jdbc-pool and
I am certainly not trying to smart ass. Its just interest and probably only a minor issue.

Thanks!
bj


Mime
View raw message