tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Burch <br...@pingtoo.com>
Subject Re: svn commit: r1484409 - in /tomcat/trunk: ./ res/ide-support/netbeans/ webapps/docs/
Date Mon, 20 May 2013 17:32:38 GMT
On 20/05/13 12:16, Mark Thomas wrote:
> On 20/05/2013 11:16, Brian Burch wrote:
>> On 20/05/13 10:53, markt@apache.org wrote:
>>> Author: markt
>>> Date: Mon May 20 09:53:25 2013
>>> New Revision: 1484409
>>>
>>> URL: http://svn.apache.org/r1484409
>>> Log:
>>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54899
>>> Provide an initial implementation of NetBeans support.
>>> Patch provided by Brian Burch.
>>>
>>> Added:
>>>       tomcat/trunk/res/ide-support/netbeans/
>>>       tomcat/trunk/res/ide-support/netbeans/README   (with props)
>>>
>>> tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties
>>> (with props)
>>>
>>> tomcat/trunk/res/ide-support/netbeans/nb-tomcat-project.properties
>>> (with props)
>>>       tomcat/trunk/res/ide-support/netbeans/nb-tomcat.xml   (with props)
>>>       tomcat/trunk/res/ide-support/netbeans/project.xml   (with props)
>> <snip/>
>>
>> Thanks very much Mark - I now have a sensible base on which to explore
>> further improvements.
>>
>> BTW.. I tried to preserve the implicit and explicit NetBeans copyright
>> notices on its auto-generated templates, while adding suitable
>> copyrights for the new apache content... did you conclude that my
>> amateur attempts were good enough? Simply passing our primitive code
>> style checks is probably not good enough!
>
> I don't see any copyright notices. I don't see any license headers either.
>
> I do see a section that looks similar to our NOTICE file.
 >
> These files appear to be auto-generated based on input you have
> provided. The only content I'm concerned about are the comments. Are
> they all yours? If so, I'll just remove the NetBeans notice. If not,
> we'll need to remove any comments that aren't yours and the notice.

I cut'n'pasted the NOTICE into each of the files, then wrapped them in 
the appropriate delimiters to render them as xml or Properties comments 
as appropriate.

You are correct that the skeletons of the two xml files were 
auto-generated based on my input, but they currently contain my attempt 
at a NetBeans attribution for the following reasons:

** project.xml is my adaptation of the default file created by NetBeans 
for a Free Form project that does not already have one. The default 
auto-generated file does NOT contain a NetBeans copyright notice, but it 
does reference netbeans schemas and is, in my naive opinion, implicitly 
copyrighted.

** nb-project.xml was created by me from scratch, but based on my 
examination of the xml files NetBeans auto-generates to support a 
project which needs to be built under a different jdk to the one 
netbeans is running under (aka the default platform). I felt I had used 
sufficient look-and-feel in my file that it would be honest to 
acknowledge the work done by the NetBeans developers on the originals.

In other words, I believe my intent is correct... but I am not confident 
I have achieved my objective. I hoped you guys could put my work right 
if necessary.

> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message