tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1484409 - in /tomcat/trunk: ./ res/ide-support/netbeans/ webapps/docs/
Date Mon, 20 May 2013 11:16:26 GMT
On 20/05/2013 11:16, Brian Burch wrote:
> On 20/05/13 10:53, markt@apache.org wrote:
>> Author: markt
>> Date: Mon May 20 09:53:25 2013
>> New Revision: 1484409
>>
>> URL: http://svn.apache.org/r1484409
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54899
>> Provide an initial implementation of NetBeans support.
>> Patch provided by Brian Burch.
>>
>> Added:
>>      tomcat/trunk/res/ide-support/netbeans/
>>      tomcat/trunk/res/ide-support/netbeans/README   (with props)
>>     
>> tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties  
>> (with props)
>>     
>> tomcat/trunk/res/ide-support/netbeans/nb-tomcat-project.properties  
>> (with props)
>>      tomcat/trunk/res/ide-support/netbeans/nb-tomcat.xml   (with props)
>>      tomcat/trunk/res/ide-support/netbeans/project.xml   (with props)
> <snip/>
> 
> Thanks very much Mark - I now have a sensible base on which to explore
> further improvements.
> 
> BTW.. I tried to preserve the implicit and explicit NetBeans copyright
> notices on its auto-generated templates, while adding suitable
> copyrights for the new apache content... did you conclude that my
> amateur attempts were good enough? Simply passing our primitive code
> style checks is probably not good enough!

I don't see any copyright notices. I don't see any license headers either.

I do see a section that looks similar to our NOTICE file.

These files appear to be auto-generated based on input you have
provided. The only content I'm concerned about are the comments. Are
they all yours? If so, I'll just remove the NetBeans notice. If not,
we'll need to remove any comments that aren't yours and the notice.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message