Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of mcintoshj@gmail.com designates
 209.85.212.43 as permitted sender)
MIME-Version: 1.0
Date: Mon, 8 Apr 2013 10:10:26 -0500
Message-ID: 
 <CAD6m6fGq03_RsoxyuOx419MJ4-U_5ZMk_7xD=g04Dnp9Z6pfYQ@mail.gmail.com>
Subject: Patches to Tomcat - number of versions and how to add a JMX attribute
From: Jason McIntosh <mcintoshj@gmail.com>
To: dev@tomcat.apache.org
Content-Type: multipart/alternative; boundary=047d7b5d45303143d404d9dad6fb

--047d7b5d45303143d404d9dad6fb
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Devs:
I wanted to get some input on this patch.  It adds the ability to specify
how many versions to remove, when undeployOldVersions is set and parallel
deployments occur.  This is my first attempt at patching tomcat, and I=92m
not totally sure I=92ve got everything, have met tomcat standards, etc.
Specifically, I'm not sure if I should really add more attributes to the
interface or not, as that could break some things if the API was set for
7.0. Here=92s the bugzilla link where I submitted this:

https://issues.apache.org/bugzilla/show_bug.cgi?id=3D54808


Additionally, I=92m working on adding a patch to add a JMX attribute on wha=
t
=93current=94 versions of any given application should be responding to
requests (tied to parallel deployments as well).  Any advice on where in
the code to start on this?  I=92m having a hard time finding where the
parallel deployment process kicks in and how to register the JMX
attribute.  For example, I saw the HostConfig class (where I added my patch
code), but I=92m not seeing any place where that shows up in JConsole.  Bas=
ed
on the mbeans descriptors, I would have thought it=92d have shown up under
Catalina/Listener but there is no such section in JConsole.  I could add a
new attribute to the Host JMX definitions to track this, but not sure
that=92s the right place either.  Wanted to get some advice on this.

Thanks!!
--=20
Jason McIntosh
http://mcintosh.poetshome.com/blog/
573-424-7612

--047d7b5d45303143d404d9dad6fb--