Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 41129F3C1 for ; Fri, 19 Apr 2013 20:32:43 +0000 (UTC) Received: (qmail 28522 invoked by uid 500); 19 Apr 2013 20:32:42 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 28449 invoked by uid 500); 19 Apr 2013 20:32:42 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 28439 invoked by uid 99); 19 Apr 2013 20:32:42 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Apr 2013 20:32:42 +0000 Received: from localhost (HELO [192.168.23.9]) (127.0.0.1) (smtp-auth username markt, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Apr 2013 20:32:41 +0000 Message-ID: <5171A9E3.6080300@apache.org> Date: Fri, 19 Apr 2013 21:32:35 +0100 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r1469891 - /tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java References: <20130419152054.222152388ACC@eris.apache.org> In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 19/04/2013 20:54, Konstantin Kolinko wrote: > 2013/4/19 : >> Author: markt >> Date: Fri Apr 19 15:20:53 2013 >> New Revision: 1469891 >> >> URL: http://svn.apache.org/r1469891 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54822 >> Fix handling of query strings with SPDY. >> Based on a patch by Sheldon Shao. >> >> Modified: >> tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java >> >> Modified: tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java >> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java?rev=1469891&r1=1469890&r2=1469891&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java (original) >> +++ tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java Fri Apr 19 15:20:53 2013 >> @@ -533,7 +533,22 @@ public class SpdyProcessor extends Abstr >> if (valueLen > frame.remaining()) { >> throw new IOException("Name too long"); >> } >> - request.requestURI().setBytes(frame.data, frame.off, valueLen); >> + >> + request.unparsedURI().setBytes(frame.data, frame.off, valueLen); >> + int questionPos = -1; >> + int end = frame.off + valueLen; >> + for(int k = frame.off; k < end; k ++) { >> + if (frame.data[k] == '?') { >> + questionPos = k; > > You are missing a "break;" here. Fixed. Thanks. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org