tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54801] EL-like expressions in jsp:scriptlet break compilation of tag files using XML syntax
Date Tue, 09 Apr 2013 22:19:03 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54801

--- Comment #2 from Konstantin Kolinko <knst.kolinko@gmail.com> ---
Created attachment 30167
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30167&action=edit
2013-04-10_tc8_54801_1.patch

1. The JSP 2.2 specification chapter JSP.1.11 EL Elements says:

"EL expressions can appear in template data and in attribute values."

I deduce that they cannot appear in scripting elements and thus trying to parse
them there is a bug.

Scripting elements are represented in Jasper by abstract Node.ScriptingElement
class. Its non-abstract derived classes are:  Declaration, Expression,
Scriptlet.


2. Parsing of EL here is performed in JspDocumentParser#processChars()

I am attaching patch that fixes processing for scripting elements in
processChars().


3. It is strange that processChars() does EL parsing regardless of
pageInfo.isELIgnored(). I suspect that it is a bug.


The code in the patch is the same as in "if (tagDependentNesting > 0)" block
there, so the two could be merged, and be also used to fix the "isELIgnored"
case.

There are no testcases in the patch yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message