tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason McIntosh <mcinto...@gmail.com>
Subject Patches to Tomcat - number of versions and how to add a JMX attribute
Date Mon, 08 Apr 2013 15:10:26 GMT
Devs:
I wanted to get some input on this patch.  It adds the ability to specify
how many versions to remove, when undeployOldVersions is set and parallel
deployments occur.  This is my first attempt at patching tomcat, and I’m
not totally sure I’ve got everything, have met tomcat standards, etc.
Specifically, I'm not sure if I should really add more attributes to the
interface or not, as that could break some things if the API was set for
7.0. Here’s the bugzilla link where I submitted this:

https://issues.apache.org/bugzilla/show_bug.cgi?id=54808



Additionally, I’m working on adding a patch to add a JMX attribute on what
“current” versions of any given application should be responding to
requests (tied to parallel deployments as well).  Any advice on where in
the code to start on this?  I’m having a hard time finding where the
parallel deployment process kicks in and how to register the JMX
attribute.  For example, I saw the HostConfig class (where I added my patch
code), but I’m not seeing any place where that shows up in JConsole.  Based
on the mbeans descriptors, I would have thought it’d have shown up under
Catalina/Listener but there is no such section in JConsole.  I could add a
new attribute to the Host JMX definitions to track this, but not sure
that’s the right place either.  Wanted to get some advice on this.

Thanks!!
-- 
Jason McIntosh
http://mcintosh.poetshome.com/blog/
573-424-7612

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message