tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1469891 - /tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java
Date Fri, 19 Apr 2013 20:32:35 GMT
On 19/04/2013 20:54, Konstantin Kolinko wrote:
> 2013/4/19  <markt@apache.org>:
>> Author: markt
>> Date: Fri Apr 19 15:20:53 2013
>> New Revision: 1469891
>>
>> URL: http://svn.apache.org/r1469891
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54822
>> Fix handling of query strings with SPDY.
>> Based on a patch by Sheldon Shao.
>>
>> Modified:
>>     tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java
>>
>> Modified: tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java?rev=1469891&r1=1469890&r2=1469891&view=diff
>> ==============================================================================
>> --- tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java (original)
>> +++ tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java Fri Apr 19 15:20:53
2013
>> @@ -533,7 +533,22 @@ public class SpdyProcessor extends Abstr
>>                  if (valueLen > frame.remaining()) {
>>                      throw new IOException("Name too long");
>>                  }
>> -                request.requestURI().setBytes(frame.data, frame.off, valueLen);
>> +
>> +                request.unparsedURI().setBytes(frame.data, frame.off, valueLen);
>> +                int questionPos = -1;
>> +                int end = frame.off + valueLen;
>> +                for(int k = frame.off; k < end; k ++) {
>> +                    if (frame.data[k] == '?') {
>> +                        questionPos = k;
> 
> You are missing a "break;" here.

Fixed. Thanks.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message