tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54552] Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener
Date Tue, 12 Feb 2013 15:36:52 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54552

--- Comment #9 from Mark Thomas <markt@apache.org> ---
Overall the patch looks pretty good.

One minor nit is the white space issues already mentioned.

The one area where I think some changes are required is listener notification
for clusters. If you look at how session destroyed events are handled, the
listeners fire on the non-primary nodes based on the value of
notifySessionListenersOnReplication. I think the same attribute should be used
to determine if the session ID change listeners are fired on the non-primary
nodes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message