tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keiichi Fujino <>
Subject Re: svn commit: r1445517 - in /tomcat/trunk: java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/session/ java/org/apache/catalina/websocket/ webapps/docs/
Date Wed, 13 Feb 2013 10:26:40 GMT
2013/2/13  <>:
> Author: markt
> Date: Wed Feb 13 09:28:58 2013
> New Revision: 1445517
> URL:
> Log:
> Fix
> Servlet 3.1
> Implement HttpSessionIdListener and HttpServletRequest#changeSessionId()
> Patch provided by Nick Williams.
I think that this code itself is not a problem at all. (I think prety good.)
However I have a idea of code improvement.

There seems to be a duplicate code on ManagerBase and DeltaManager.
By introducing a following method to ManagerBase and DeltaManager,
we might be able to avoid code duplication.

changeSessionId(Session session, String newId)
changeSessionId(Session session, String newId,
    boolean notifySessionListeners, boolean notifyContainerListeners)

And furthermore, we are changing sessionId in JvmRouteBinderValve.
Change sessionid of JvmRouteBinderValve is completely different from
By using new changeSessionId method, will be able to change sessionId
in a same way.
As a result, JvmRouteSessionIDBinderListener will be unnecessary.

I'm going to fix these improvements If there is no objections from anyone.
Any objections and comment?


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message