tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject JarScanning
Date Thu, 21 Feb 2013 16:34:48 GMT
An issue at work prompted me to take another look at this thread:
http://markmail.org/thread/qanw2psjsx32feek

There are some useful things there that I think it is worth following up on.

JRE JARs.
I think scanning of these should be made optional and disabled by
default. This will reduce the list of JARs we have to maintain in
jarsToSkip. I intend to implement this unless there are any objections.


jarsToScan
This is a little more complicated.
First of all, how does it work? The suggestion is:
- If jarsToScan matches, scan it
- else if jarsToSkip matches, skip it
- else scan it

Assuming that the above is acceptable, it would require the following:
a) three new system properties
     tomcat.util.scan.DefaultJarScanner.jarsToScan
     org.apache.catalina.startup.ContextConfig.jarsToScan
     org.apache.catalina.startup.TldConfig.jarsToScan
b)  add a parameter to JarScanner.scan()

There are a couple of issues here.

1. Backwards compatibility. Adding the parameter to JarScanner.scan()
will break any custom Jar scanners. Without that parameter it would not
be possible to have different jarsToScan for pluggability and TLDs.

2. (and an issue with the current code [1]). These settings are all
global rather than per web application. I would prefer that they were
per web application with defaults configured globally. It is complicated
by the fact that the JARs to skip/scan may vary depending on how the
JarScanner is used.

Thoughts?

Mark



[1] https://issues.apache.org/bugzilla/show_bug.cgi?id=54083

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message