tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Question about bug 54284
Date Thu, 03 Jan 2013 14:52:10 GMT
On 03/01/2013 14:30, Violeta Georgieva wrote:

> I think that when the filter name is NULL the proper behaviour is to return
> IllegalArgumentException.
> From other point of view the method's javadoc specifies only
> IllegalStateException and UnsupportedOperationException.
> If the method starts returning IllegalArgumentException it will be
> backwards incompatible change and also not compliant with the specification.
> 
> What do you think?

I think that there is strong implication from the Javadoc that the name
is required. That said, when using this API a name isn't absolutely
necessary so it could be made optional (ignoring the JMX name issues).

IllegalArgumentException is a runtime exception so as long as it is not
added to the method signature (it doesn't need to be) that will not
break the API tests in the TCK.

> Are there any clarifications in the Servlet 3.1 specification?

Not that I am aware of. I'd suggest creating a Jira issue and requesting
clarification. I usually find to helpful to suggest a solution in the
Jira which in this case I think is that the name should be required.

The issue can be left in the NEEDINFO state with a link to the Servlet
Jira until we get clarification.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message