tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1434731 - /tomcat/trunk/res/findbugs/filter-false-positives.xml
Date Thu, 17 Jan 2013 15:38:41 GMT
Author: markt
Date: Thu Jan 17 15:38:40 2013
New Revision: 1434731

URL: http://svn.apache.org/viewvc?rev=1434731&view=rev
Log:
More FindBugs false positives

Modified:
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1434731&r1=1434730&r2=1434731&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Thu Jan 17 15:38:40 2013
@@ -333,16 +333,20 @@
     <Bug code="MF" />
   </Match>
   <Match>
-    <!-- addCount is modified in other threads -->
+    <!-- See wait() call in destroy() -->
     <Class name="org.apache.tomcat.util.net.AprEndpoint$Poller"/>
     <Method name="run"/>
     <Bug code="NN" />
   </Match>
   <Match>
-    <!-- addCount is modified in other threads -->
     <Class name="org.apache.tomcat.util.net.AprEndpoint$Sendfile"/>
     <Method name="run"/>
-    <Bug code="NN" />
+    <Or>
+      <!-- see wait() call in destroy() -->
+      <Bug code="NN" />
+      <!-- notify() is called from add() -->
+      <Bug code="UW" />
+    </Or>
   </Match>
   <Match>
     <!-- Sync is there to protect referenced object not field -->



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message