Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
User-Agent: K-9 Mail for Android
In-Reply-To: 
 <CABzHfVmjN29B4N8poO-s-2jcLh8ZVFMZnEHercVNrcmKNOKYaA@mail.gmail.com>
References: <20121205225223.75E8F23889E0@eris.apache.org>
 <CABzHfVmjN29B4N8poO-s-2jcLh8ZVFMZnEHercVNrcmKNOKYaA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: svn commit: r1417683 - in
 /tomcat/trunk/java/org/apache/tomcat/websocket: ClientContainerImpl.java
 PojoServerEndpointConfiguration.java ServerContainerImpl.java
 WsEndpointPojo.java WsFrame.java WsServlet.java WsSession.java
From: Mark Thomas <markt@apache.org>
Date: Thu, 06 Dec 2012 12:47:48 +0000
To: Tomcat Developers List <dev@tomcat.apache.org>
Message-ID: <635278b5-3181-4cc6-9ce3-848bae7eff2b@email.android.com>

Konstantin Kolinko <knst.kolinko@gmail.com> wrote:

>2012/12/6  <markt@apache.org>:
>> Author: markt
>> Date: Wed Dec  5 22:52:21 2012
>> New Revision: 1417683
>>
>> URL: http://svn.apache.org/viewvc?rev=1417683&view=rev
>> Log:
>> Update implementation for API changes
>>
>> Added:
>>    
>tomcat/trunk/java/org/apache/tomcat/websocket/PojoServerEndpointConfiguration.java
>  (with props)
>> Modified:
>>    
>tomcat/trunk/java/org/apache/tomcat/websocket/ClientContainerImpl.java
>>    
>tomcat/trunk/java/org/apache/tomcat/websocket/ServerContainerImpl.java
>>     tomcat/trunk/java/org/apache/tomcat/websocket/WsEndpointPojo.java
>>     tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java
>>     tomcat/trunk/java/org/apache/tomcat/websocket/WsServlet.java
>>     tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
>>
>
>
>> Added:
>tomcat/trunk/java/org/apache/tomcat/websocket/PojoServerEndpointConfiguration.java
>> URL:
>http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/PojoServerEndpointConfiguration.java?rev=1417683&view=auto
>>
>==============================================================================
>> ---
>tomcat/trunk/java/org/apache/tomcat/websocket/PojoServerEndpointConfiguration.java
>(added)
>> +++
>tomcat/trunk/java/org/apache/tomcat/websocket/PojoServerEndpointConfiguration.java
>Wed Dec  5 22:52:21 2012
>> +package org.apache.tomcat.websocket;
>> +
>> +import javax.websocket.DefaultServerConfiguration;
>> +import javax.websocket.Endpoint;
>> +import javax.websocket.EndpointFactory;
>> +
>> +public class PojoServerEndpointConfiguration extends
>> +        DefaultServerConfiguration<Endpoint> {
>> +
>> +    @Override
>> +    public boolean checkOrigin(String originHeaderValue) {
>> +        // Allow all
>> +        return true;
>> +    }
>> +
>> +    private final EndpointFactory<Endpoint> endpointFactory;
>> +    private final String servletPath;
>> +
>> +    PojoServerEndpointConfiguration(Class<?> pojo,
>> +            PojoMethodMapping methodMapping, String servletPath,
>String pathInfo) {
>> +        this.endpointFactory =
>> +                new PojoEndpointFactory(pojo, methodMapping,
>pathInfo);
>> +        this.servletPath = servletPath;
>> +    }
>> +
>
>(...)
>
>Was it intended to make the constructor package-visible? If it is then
>the class itself could be made package-visible, for consistency.  My
>guess that was a typo. The PojoMethodMapping class is already public
>and this one does not add much.
>
>Best regards,
>Konstantin Kolinko
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>For additional commands, e-mail: dev-help@tomcat.apache.org

Yes, it was an oversight. I intend to review all the visibilities once the implementation is complete.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org