tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54239] Extensible EL Interpreter
Date Tue, 04 Dec 2012 08:37:15 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54239

--- Comment #3 from Mark Thomas <markt@apache.org> ---
Comment on attachment 29685
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29685
ELInterpreterFactory

In principle this looks like a good idea.

I have a couple of concerns with the patch as currently written:
1. No documentation.
2. No test cases.
3. The use of enum for the default instance is rather odd.
4. I dislike the use of system properties when they are not necessary. If the
class name was handled as a servlet context initialization parameters then
Tomcat already has the necessary plumbing for global, per host and per web
application configuration.
5. Error messages need to use the standard i18n support.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message