tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1417424 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/AccessLogValve.java
Date Wed, 05 Dec 2012 14:30:23 GMT
2012/12/5  <rjung@apache.org>:
> Author: rjung
> Date: Wed Dec  5 14:00:15 2012
> New Revision: 1417424
>
> URL: http://svn.apache.org/viewvc?rev=1417424&view=rev
> Log:
> - Style
> - Fix Javadoc
> - Move default setting to the right place.

By a quick look: You say "move", but I see only the new code and no
removed code.
Is it as intended?


> - remove obsolete comment warning.
>
> Backport of r1417347, r1417348 and
> partially r1417353.
>
> Modified:
>     tomcat/tc7.0.x/trunk/   (props changed)
>     tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java
>
> Propchange: tomcat/tc7.0.x/trunk/
> ------------------------------------------------------------------------------
>   Merged /tomcat/trunk:r1417347-1417348,1417353
>
> Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java
> URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=1417424&r1=1417423&r2=1417424&view=diff
> ==============================================================================
> --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java (original)
> +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java Wed Dec
 5 14:00:15 2012
> @@ -239,8 +239,8 @@ public class AccessLogValve extends Valv
>
>
>      /**
> -     * A date formatter to format a Date into a date in the format
> -     * "yyyy-MM-dd".
> +     * A date formatter to format a Date using the format
> +     * given by <code>fileDateFormat</code>.
>       */
>      protected SimpleDateFormat fileDateFormatter = null;
>
> @@ -529,9 +529,9 @@ public class AccessLogValve extends Valv
>      protected String conditionIf = null;
>
>      /**
> -     * Date format to place in log file name. Use at your own risk!
> +     * Date format to place in log file name.
>       */
> -    protected String fileDateFormat = null;
> +    protected String fileDateFormat = "yyyy-MM-dd";
>
>
>      /**
> @@ -856,7 +856,7 @@ public class AccessLogValve extends Valv
>       *  Set the date format date based log rotation.
>       */
>      public void setFileDateFormat(String fileDateFormat) {
> -        this.fileDateFormat =  fileDateFormat;
> +        this.fileDateFormat = fileDateFormat;
>      }
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message